Don't wrap due to trailing space #310
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The line wrapper considers trailing space part of a word, and so it will bump words to the next line when they really would have fit.
|
I believe I'm running into this same issue here. This PR is hopelessly outdated, I'm afraid I'll have to redo this same exercise on the current codebase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The line wrapper considers trailing space part of a word, so it will bump words to the next line when they really would have fit.
This change tracks the amount of trailing space in the word so we can choose to only wrap when the word itself would overflow beyond the available width.
Here is a document that shows the same text rendered before and after this code change.